Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show correct image on variants #1610

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Nov 11, 2024

What/Why?

  • Append default image if found to Gallery, show result first.
  • Use first image from image in description.
variant-image.mp4

Testing

Locally.

Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: ba0754b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 0:48am
catalyst-latest 🛑 Canceled (Inspect) 💬 Add feedback Nov 11, 2024 0:48am
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 0:48am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 0:48am
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 0:48am
catalyst-unstable ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 0:48am

@bookernath
Copy link
Contributor

🍹 consider appending at the end, not the beginning

@jorgemoya jorgemoya merged commit 8daa96e into vibes/soul-with-makeswift Nov 11, 2024
9 checks passed
@jorgemoya jorgemoya deleted the vibes/soul-fix-images-variant branch November 11, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants