feat: visually editable site theme #1614
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
agurtovoy
changed the title
| <NextIntlClientProvider locale={locale} messages={messages}> | ||
| <NuqsAdapter> | ||
| <MakeswiftProvider previewMode={draftMode().isEnabled}> | ||
| <MakeswiftProvider previewMode={draftMode().isEnabled}> |
There was a problem hiding this comment.
Moved up <MakeswiftProvider> so that it wraps the whole document, including <head> where <CssTheme> is injecting the styles.
| --contrast-200: 0 0% 82%; | ||
| --contrast-300: 0 0% 70%; | ||
| --contrast-400: 0 0% 54%; | ||
| --contrast-500: 0 0% 34%; |
There was a problem hiding this comment.
Moved out of CSS to a Typescript file so we can reuse these values in theme component registration to provide props with default values.
There was a problem hiding this comment.
I'm wondering if there's a better way than deleting things for when we need to separate Makeswift related integration code from main. Ideally we don't have to delete anything from the base repo, just add Makeswift related code. Maybe that's wishful thinking.
There was a problem hiding this comment.
I think this is a good goal and we can accomplish it by overriding these values with Makeswift CSS variables further down. That being said, sometimes conflicts are good as we would want to know when this list changes to that we can do the equivalent change on integrations/makeswift.
agurtovoy
force-pushed
the
aleksey/vib-851-add-theme-embedded-component-for-tailwind-colors
branch
from
8223d94
to
e73a2e5
Compare
agurtovoy
force-pushed
the
aleksey/vib-851-add-theme-embedded-component-for-tailwind-colors
branch
from
e73a2e5
to
698c6cb
Compare
| --contrast-200: 0 0% 82%; | ||
| --contrast-300: 0 0% 70%; | ||
| --contrast-400: 0 0% 54%; | ||
| --contrast-500: 0 0% 34%; |
There was a problem hiding this comment.
I'm wondering if there's a better way than deleting things for when we need to separate Makeswift related integration code from main. Ideally we don't have to delete anything from the base repo, just add Makeswift related code. Maybe that's wishful thinking.
apledger
deleted the
aleksey/vib-851-add-theme-embedded-component-for-tailwind-colors
branch
Kapture.2024-11-10.at.23.24.02.mp4