You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a few issues with the playwright test suite:
--disable-web-security
We were running into a CORS issue when redirecting to checkout from a HeadlessChromesec-ch-ua user agent. When the browser sent preflight requests to BigCommerce assets, we were denied access to the loader.js asset which cause checkout to not load.
I attempted to set a new User Agent for playwright requests, but the sec-ch-ua header disallows tampering to it, thus rejecting the request. I tried something like this but failed: microsoft/playwright#27903 (comment)
Other fixes
Cleaned up some unused exports and tweaked the session syncing test to actually work and updated a snapshot with new functionality.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chanceaclark
force-pushed
the
chore/fix-tests
branch
from
What/Why?
Fixes a few issues with the playwright test suite:
--disable-web-securityWe were running into a CORS issue when redirecting to checkout from a
HeadlessChromesec-ch-uauser agent. When the browser sent preflight requests to BigCommerce assets, we were denied access to theloader.jsasset which cause checkout to not load.I attempted to set a new User Agent for playwright requests, but the
sec-ch-uaheader disallows tampering to it, thus rejecting the request. I tried something like this but failed: microsoft/playwright#27903 (comment)Other fixes
Cleaned up some unused exports and tweaked the session syncing test to actually work and updated a snapshot with new functionality.
Testing
See CI.