Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run root lint task with env #1654

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: run root lint task with env #1654

merged 1 commit into from
Nov 18, 2024

Conversation

matthewvolk
Copy link
Contributor

What/Why?

Some users get the following error when trying to run pnpm run lint:

/Users/user.name/catalyst/packages/client/dist/index.js:153
      throw new Error("Client configuration must include a channelId.");
            ^

Error: Client configuration must include a channelId.
    at new Client (/Users/user.name/catalyst/packages/client/dist/index.js:153:13)
    ...

This PR adds env awareness to tasks run from root which should fix the issue

Testing

Locally

@matthewvolk matthewvolk requested a review from a team as a code owner November 18, 2024 20:49
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 4a08582

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 8:50pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Nov 18, 2024 8:50pm
catalyst-au ⬜️ Ignored (Inspect) Nov 18, 2024 8:50pm
catalyst-soul ⬜️ Ignored (Inspect) Nov 18, 2024 8:50pm
catalyst-uk ⬜️ Ignored (Inspect) Nov 18, 2024 8:50pm
catalyst-unstable ⬜️ Ignored (Inspect) Nov 18, 2024 8:50pm

@bookernath bookernath added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 179950a Nov 18, 2024
12 of 13 checks passed
@bookernath bookernath deleted the fix/lint-with-env branch November 18, 2024 21:29
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-4hazq151u-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 80
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants