Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1646 Top Global Region Image Widget overlaps the mobile menu #2402

Merged

Conversation

bc-yevhenii-buliuk
Copy link
Contributor

@bc-yevhenii-buliuk bc-yevhenii-buliuk commented Nov 27, 2023

What?

This PR fixes a bug with overlaps in the mobile menu.

Tickets / Documentation

Screenshots / Video

Bug:

1646_bug.mov

Fix:

1646_fix.mov

@bc-yevhenii-buliuk bc-yevhenii-buliuk self-assigned this Nov 27, 2023
@bc-yevhenii-buliuk
Copy link
Contributor Author

@bigcommerce/team-themes how do you think, is it Ok that the yellow banner overlaps the main carousel as well?

@bc-yevhenii-buliuk bc-yevhenii-buliuk requested a review from a team November 27, 2023 13:50
Copy link
Contributor

@yurytut1993 yurytut1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bc-alexsaiannyi bc-alexsaiannyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bc-yevhenii-buliuk bc-yevhenii-buliuk merged commit 99a7a42 into bigcommerce:master Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants