Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storefront): BCTHEME-1748 Check lang helpers usage and existence of key in translation file #2403

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(storefront): BCTHEME-1748 Check lang helpers usage and existence of key in translation file #2403

merged 1 commit into from
Dec 6, 2023

Conversation

bc-vlad-dlogush
Copy link
Contributor

@bc-vlad-dlogush bc-vlad-dlogush commented Nov 28, 2023 •
edited by jira bot
Loading

What?

This PR fixes an issue with displaying warnings in the terminal.

Tickets / Documentation

Screenshots / Screen Recording

Before

Screen.Recording.2023-11-24.at.11.49.49.mov

After

Screenshot 2023-11-28 at 11 16 02

@bc-vlad-dlogush bc-vlad-dlogush requested a review from a team November 28, 2023 09:37
@bc-vlad-dlogush bc-vlad-dlogush self-assigned this Nov 28, 2023
@bc-vlad-dlogush
Copy link
Contributor Author

By default, translations from en.json were taken and the storefront was displayed correctly, but with the help of lang helper, warnings were displayed in the terminal about the lack of translations for certain phrases in en-CA.json, so translations from en.json were used to avoid warnings. Everything is fine here

We have a similar situation with fr.json and fr-CA.json and everything works fine too, but there are no warnings in the terminal about the lack of translations for certain phrases of fr-CA.json.

BC-krasnoshapka
BC-krasnoshapka requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@BC-krasnoshapka BC-krasnoshapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladDlogush both en-CA and fr-CA are not officially supported by BigCommerce, automatic translations are not delivered and storefront should fallback to en and fr respectfully. Thus we can delete both files. Please check that errors in CLI are gone.

@bc-vlad-dlogush
Copy link
Contributor Author

@BC-krasnoshapka Done!

bc-yevhenii-buliuk
bc-yevhenii-buliuk reviewed Nov 28, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@bc-vlad-dlogush bc-vlad-dlogush merged commit e35b208 into master Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BC-krasnoshapka BC-krasnoshapka BC-krasnoshapka approved these changes

@bc-yevhenii-buliuk bc-yevhenii-buliuk bc-yevhenii-buliuk approved these changes

@bc-alexsaiannyi bc-alexsaiannyi bc-alexsaiannyi approved these changes

@yurytut1993 yurytut1993 yurytut1993 approved these changes

Assignees

@bc-vlad-dlogush bc-vlad-dlogush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bc-vlad-dlogush @yurytut1993 @bc-alexsaiannyi @bc-yevhenii-buliuk @BC-krasnoshapka @VladDlogush