Fix 1103 by evaluating hx-vals with this referring to the element #3139
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1103 by evaluating
hx-vals
attributes withthis
referring to the current element.Example:
evaluates to
{ "name": "a name", "hello": "world" }
sincethis
refers to the div with hx-vals attribute.Corresponding issue: #1103
Testing
Added a test in test/attributes/hx-vals.js. This tests that
this
acually refers to the current element.Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeededEdit: May also fix #1658