Skip to content

Commit

Permalink
Add some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Croydon committed Jun 6, 2024
1 parent d311691 commit 10900fc
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ def check_for_deprecated_settings(main, file):
"""
settings = main._compat_api.graph.compat_inspect_attribute(conanfile=file, attribute="settings")

# Conan >= 1.15.0
if settings and "cppstd" in settings:
main.output_result_check(passed=False, title="Deprecated settings",
reason=f"deprecated attribute(s): {settings}")
Expand Down
11 changes: 11 additions & 0 deletions bincrafters_conventions/actions/update_c_imports.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,22 @@ def update_c_imports(main, file):

imports = {}
# Schema:
#
# first line: from original_X import original_Y -> ("original_X", "original_Y")
# second line: from updated_X import updated_Y -> ("updated_X", "updated_Y")
# third line: ("min Conan version the new import works", "first Conan version the new import BREAKS, doesn't work anymore, add * if there is no such version yet")
# for the imported symbols:
#
# * is both a literal * from imports, but also telling the script to just leave unchaged whatever was imported; useful for just changing from where you import
#
# Another example, updating an import in the form of
# import os
# to
# import shiny_new_os
# can be archived with
# [("*", "os"), ("*", "shiny_new_os"), ("*", "*")]
#

imports_updates_conan = [
# Conan 1.15
[
Expand Down

0 comments on commit 10900fc

Please sign in to comment.