This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Fixed - Do not check for version if user enters latest #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
sarthak-sehgal
approved these changes
Aug 25, 2019
|
@Nikhil-Vats is the check for the term “latest” case sensitive? 🤔 |
|
Yes @sarthak-sehgal, the npm view command works only if version is "latest", it is case sensitive and the code checks that. |
|
I feel that it should be case insensitive. Sorry about not mentioning it earlier! |
|
Merging for now as this is blocking release of a new version. Raised #38 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the version is latest, the generator does need not check if its valid as
latestautomatically means the latest version on npm. This saves time.Related issues and discussion
#26
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!