fix(parser): export_named_type should parse default as normal #4903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Parser
fireairforce
force-pushed
the
fix-4765
branch
2 times, most recently
from
f0b123b to
293ba94
Compare
CodSpeed Performance ReportMerging #4903 will not alter performanceComparing Summary
|
This comment was marked as resolved.
This comment was marked as resolved.
ematipico
requested changes
Jan 20, 2025
| @@ -0,0 +1,13 @@ | |||
| --- | |||
| biome_js_parser: patch | |||
There was a problem hiding this comment.
You must add the cli package too. Please read the contribution guide regarding the changesets
There was a problem hiding this comment.
done, thanks for the reminder.
fireairforce
force-pushed
the
fix-4765
branch
2 times, most recently
from
a6af0c9 to
339feb4
Compare
|
it seems the ci not stable... |
fireairforce
force-pushed
the
fix-4765
branch
from
339feb4 to
5dbc643
Compare
ematipico
reviewed
Jan 20, 2025
crates/biome_analyze/src/lib.rs
Outdated
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| use biome_console::markup; | |||
| use biome_parser::AnyParse; | |||
| use std::cmp::Ordering; | |||
There was a problem hiding this comment.
I think you made a mistake and added a commit/change from the other PR
There was a problem hiding this comment.
sorry, my git broken, i fix this
fireairforce
force-pushed
the
fix-4765
branch
from
5dbc643 to
e0efc89
Compare
ematipico
reviewed
Jan 20, 2025
| @@ -954,6 +954,7 @@ where | |||
| // { type as } // name: `as` type-export: `true` | |||
| // { type as as } // name: `type` type-export: `false` (aliased to `as`) | |||
| // { type as as as } // name: `as` type-export: `true`, aliased to `as` | |||
| // { type default as as } // name: 'as' type-export: `true`, aliased to `as` | |||
There was a problem hiding this comment.
We don't use inline tests anymore. They were left there after we moved to a new testing infrastructure, so there's no need to add new comments like this one
fireairforce
force-pushed
the
fix-4765
branch
from
e0efc89 to
176d6f2
Compare
ematipico
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #4765
Summary
The following code:
it should be parsed without error.
I just add a simple judge when parser meet
T![default], and deal this to type alias, so it can be parsed successfully.Test Plan
i add test case.