Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch js-api openProject() #5000

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

ianzone
Copy link
Contributor

@ianzone ianzone commented Jan 31, 2025

Summary

definition openProject(): void; is redundant and will emit type error when passing the path param, so it's removed. Also, the jsDoc is added to openProject(path).

Test Plan

@github-actions github-actions bot added the A-Changelog Area: changelog label Jan 31, 2025
@ematipico
Copy link
Member

Thank you. Can you please rebase your branch and add a changelog? The contribution guide in the next branch has been updated

@ianzone
Copy link
Contributor Author

ianzone commented Feb 8, 2025

Thank you. Can you please rebase your branch and add a changelog? The contribution guide in the next branch has been updated

command not found
image

@ematipico
Copy link
Member

You need to run pnpm i from the root of the monorepo

@ianzone
Copy link
Contributor Author

ianzone commented Feb 9, 2025

You need to run pnpm i from the root of the monorepo

image

this is misleading, the command should be pnpm changeset.

@github-actions github-actions bot removed the A-Changelog Area: changelog label Feb 9, 2025
@ianzone
Copy link
Contributor Author

ianzone commented Feb 9, 2025

updated

@ematipico
Copy link
Member

You need to run pnpm i from the root of the monorepo

image

this is misleading, the command should be pnpm changeset.

The contribution guide was updated and probably missed it.

Plus, we are very explicit regarding the fact that we use just for the task runner. Many commands use other tools under the hoods (cargo, pnpm, taplo, etc), but it's more consistent to use one tool on the surface.

@ianzone
Copy link
Contributor Author

ianzone commented Feb 10, 2025

it turns out I didn't install cargo pkgs, now it should be fine.

.changeset/spotty-hounds-tie.md Outdated Show resolved Hide resolved
@ematipico ematipico merged commit 4de5de8 into biomejs:next Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants