fix: repair explosive memory leak in GritQL parser #5033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5032 to prevent the parser from consuming infinite memory.
We previously only consumed new-lines in debug builds: https://github.com/biomejs/biome/pull/5033/files#diff-15e627641974e3cc1e6efc62bdc4b632ca41315fa8cc7b5bf3dd50c40df65d3eL183
This of course is very problematic when trying to use the parser in a released build.
Test Plan
Since this behavior only shows up in release builds, I don't have a simple way to run the tests unless we want to switch CI to use the
--release
profile for running tests.