feat(biome_js_formatter): introduce the new objectWrap option #5068
+872
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naoki Ikeguchi <[email protected]>
Signed-off-by: Naoki Ikeguchi <[email protected]>
…ectWrap is collapse Signed-off-by: Naoki Ikeguchi <[email protected]>
Signed-off-by: Naoki Ikeguchi <[email protected]>
Signed-off-by: Naoki Ikeguchi <[email protected]>
Signed-off-by: Naoki Ikeguchi <[email protected]>
Signed-off-by: Naoki Ikeguchi <[email protected]>
github-actions
bot
added
A-CLI
siketyan
changed the title
siketyan
changed the title
… snippets as Prettier Signed-off-by: Naoki Ikeguchi <[email protected]>
CodSpeed Performance ReportMerging #5068 will not alter performanceComparing Summary
|
dyc3
requested changes
Feb 9, 2025
Comment on lines
582
to
583
| "as-needed" => Ok(Self::Preserve), | ||
| "always" => Ok(Self::Collapse), |
There was a problem hiding this comment.
This doesn't look right.
Suggested change
| "as-needed" => Ok(Self::Preserve), | |
| "always" => Ok(Self::Collapse), | |
| "preserve" => Ok(Self::Preserve), | |
| "collapse" => Ok(Self::Collapse), |
There was a problem hiding this comment.
My bad, thank you for catching this. Fixed in 5eb499b
| @@ -103,6 +103,11 @@ pub struct JsFormatterConfiguration { | |||
| #[bpaf(long("bracket-spacing"), argument("true|false"))] | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| pub bracket_spacing: Option<BracketSpacing>, | |||
|
|
|||
| /// Whether to enforce collapsing object literals when possible. Defaults to preserve. | |||
| #[bpaf(long("object-wrap"), argument("preserve|collapse"))] | |||
There was a problem hiding this comment.
This argument should be prefixed with javascript, like the args are since this is javascript specific. eg --javascript-object-wrap
Suggested change
| #[bpaf(long("object-wrap"), argument("preserve|collapse"))] | |
| #[bpaf(long("javascript-object-wrap"), argument("preserve|collapse"))] |
Signed-off-by: Naoki Ikeguchi <[email protected]>
Signed-off-by: Naoki Ikeguchi <[email protected]>
Signed-off-by: Naoki Ikeguchi <[email protected]>
|
I don't see any new snapshots added. Can you please point me to those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prettier 3.5 introduced a new Object Wrap option. This improves code consistency, so it will be great if Biome also support this option.
This pull request introduces the
objectWrapoption to enforce collapsing object literals when possible.Test Plan
Snapshot test cases added.