feat(playground): add html formatter options #1741
Open
+100
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dyc3
force-pushed
the
playground-html-options
branch
from
fddfd99 to
f700783
Compare
dyc3
force-pushed
the
playground-html-options
branch
from
f700783 to
1298464
Compare
chansuke
reviewed
Feb 15, 2025
| if (key.startsWith("ruleDomains.")) { | ||
| const domain = key.slice("ruleDomains.".length); | ||
| const value = searchParams.get(key); | ||
| if (value !== null) { |
There was a problem hiding this comment.
i believe you did this intentionally, but you might be able to simplify it as follows?:
Suggested change
| if (value !== null) { | |
| if (value) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds HTML specific formatter options to the playground's settings. I've verified that they get passed into both biome and prettier's configuration. It won't be obvious it's working for biome's formatter because the logic for these options isn't entirely complete in biome.
Caution
This PR is stacked on the following PRs. Do not merge it without merging the others and rebasing this branch. To review this PR, look at the last commit only.