-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefix: icd11.foundation #1345
Conversation
Thanks @sierra-moxon, I closed the other PRs and we can look at this to finalize things! In case you'd like to make changes to the PR yourself, it's best if you:
|
thanks @bgyori I went ahead and made the PR in biolink to address this issue: https://github.com/biolink/biolink-model/pull/1540/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be a misunderstanding between what constitute the ICD11 semantic space and the various providers (Foundation, API, Mortality and Morbidity Statistics).
New PR incoming that makes this more clear. See #1346
I took a look at this and agree with @cthoyt's conclusions. My understanding is (also) that the prefix for ICD11 identifiers is already available at As @cthoyt mentioned in a comment, it is actually possible to resolve a CURIE with a specific provider of your choice, in this case, if you want to resolve an ICD11 identifier with ICD11 Foundation, you can do https://bioregistry.io/icd11:402558626?provider=foundation (just note that the latest change in #1346 has not been deployed yet to the public service so this link will only become live later). In addition, as also mentioned in #1346 (comment), we could add something like How should we proceed? |
I think there is a big misunderstanding here.. icd11 the terminology and icd11.foundation have absolutely nothing in common.. they are two completely disjoint identifier spaces that are only connected through some ETL pipeline at WHO. Please do not conflate these.. in fact, there will be SSSOM file soon from ICD11 to icd11 foundation.. |
Apologies if this is indeed a big misunderstanding! To help me understand, it would be helpful to see an example of an identifier that is specific to icd11.foundation. The reason I think I was confused is that in this PR, the example |
No problem, I moved the discussion back to the issue for future reference: #1344 |
done now in #1352 closing pending who feedback |
Closes #1344