Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix: icd11.foundation #1345

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 6, 2025

Closes #1344

@github-actions github-actions bot added New Used in combination with prefix, metaprefix, or collection for new entries Prefix labels Jan 6, 2025
@bgyori
Copy link
Contributor

bgyori commented Jan 6, 2025

Thanks @sierra-moxon, I closed the other PRs and we can look at this to finalize things! In case you'd like to make changes to the PR yourself, it's best if you:

  • Fork the repository and work on a branch
  • Push the branch to your own fork
  • Pull request from your own fork's branch to this PR branch (or just let me know and I can integrate your commits and push to this branch if that's easier)

@sierra-moxon
Copy link
Contributor

sierra-moxon commented Jan 6, 2025

thanks @bgyori

I went ahead and made the PR in biolink to address this issue: https://github.com/biolink/biolink-model/pull/1540/files

Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a misunderstanding between what constitute the ICD11 semantic space and the various providers (Foundation, API, Mortality and Morbidity Statistics).

New PR incoming that makes this more clear. See #1346

@bgyori
Copy link
Contributor

bgyori commented Jan 8, 2025

I took a look at this and agree with @cthoyt's conclusions. My understanding is (also) that the prefix for ICD11 identifiers is already available at icd11. ICD11 Foundation is a specific rendering of ICD11 identifiers and is therefore best considered a provider for the icd11 prefix.

As @cthoyt mentioned in a comment, it is actually possible to resolve a CURIE with a specific provider of your choice, in this case, if you want to resolve an ICD11 identifier with ICD11 Foundation, you can do https://bioregistry.io/icd11:402558626?provider=foundation (just note that the latest change in #1346 has not been deployed yet to the public service so this link will only become live later).

In addition, as also mentioned in #1346 (comment), we could add something like icd11.foundation or some other variant of this as a synonym for icd11 which would then allow using icd11.foundation in CURIEs and have them both be normalizable to the canonical prefix and be resolvable if used in bioregistry.io-based URLs.

How should we proceed?

@matentzn
Copy link
Collaborator

matentzn commented Jan 8, 2025

I think there is a big misunderstanding here.. icd11 the terminology and icd11.foundation have absolutely nothing in common.. they are two completely disjoint identifier spaces that are only connected through some ETL pipeline at WHO. Please do not conflate these.. in fact, there will be SSSOM file soon from ICD11 to icd11 foundation..

@bgyori
Copy link
Contributor

bgyori commented Jan 8, 2025

Apologies if this is indeed a big misunderstanding!

To help me understand, it would be helpful to see an example of an identifier that is specific to icd11.foundation. The reason I think I was confused is that in this PR, the example icd11.foundation identifier added is 1048673005 which can be plugged in to the default resolver for icd11, i.e., https://bioregistry.io/icd11:1048673005, to arrive at the exact same term, as what you get when you plug it into the uri_format added in this PR for icd11.foundation, i.e., https://id.who.int/icd/entity/1048673005. This specific example, therefore, is perhaps misleading in that it makes it seem as if the identifiers are shared across the two resources.

@matentzn
Copy link
Collaborator

matentzn commented Jan 9, 2025

No problem, I moved the discussion back to the issue for future reference: #1344

@matentzn
Copy link
Collaborator

done now in #1352 closing pending who feedback

@matentzn matentzn closed this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Used in combination with prefix, metaprefix, or collection for new entries Prefix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICD11 Discussion
4 participants