-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor paper ranking workflow #1358
Conversation
I think restructuring the code is okay, without going into discussions about detailed choices, perhaps @nagutm could check to see if there are any unintended changes to the overall behavior we need to address. I think we should look into the reldate / explicit start and end date discrepancy on a separate PR to not mix refactoring with that (That issue happens to not make a practical difference in the monthly runs but is generally something we should fix.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the basic functionality with the refactored code and there does not appear to be any unexpected changes to the general workflow. I think we can merge this PR in order to address the issue of the start and end dates.
This PR refactors the paper ranking workflow with the following:
It also does: