Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search PubMed Papers In Specific Date Range for Paper Ranking Workflow #1367

Merged
merged 19 commits into from
Jan 20, 2025

Conversation

nagutm
Copy link
Collaborator

@nagutm nagutm commented Jan 19, 2025

This pull request addresses the issue outlined in this comment: #1350 (comment)

The reldate parameter was replaced by mindate and maxdate in the functions responsible for searching relevant PubMed papers.

This ensures that the PubMed papers fetched within the desired date range is consistent with the start_date and end_date parameters in the main function.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.27%. Comparing base (8950e70) to head (1001665).
Report is 275 commits behind head on main.

Files with missing lines Patch % Lines
src/bioregistry/analysis/paper_ranking.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1367      +/-   ##
==========================================
+ Coverage   42.51%   46.27%   +3.75%     
==========================================
  Files         117      118       +1     
  Lines        8327     8301      -26     
  Branches     1963     1357     -606     
==========================================
+ Hits         3540     3841     +301     
+ Misses       4582     4275     -307     
+ Partials      205      185      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgyori bgyori merged commit fccbfae into biopragmatics:main Jan 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants