-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search PubMed Papers In Specific Date Range for Paper Ranking Workflow #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…registry into add_paper_rankings_to_exports
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
==========================================
+ Coverage 42.51% 46.27% +3.75%
==========================================
Files 117 118 +1
Lines 8327 8301 -26
Branches 1963 1357 -606
==========================================
+ Hits 3540 3841 +301
+ Misses 4582 4275 -307
+ Partials 205 185 -20 ☔ View full report in Codecov by Sentry. |
cthoyt
reviewed
Jan 19, 2025
bgyori
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue outlined in this comment: #1350 (comment)
The
reldate
parameter was replaced bymindate
andmaxdate
in the functions responsible for searching relevant PubMed papers.This ensures that the PubMed papers fetched within the desired date range is consistent with the
start_date
andend_date
parameters in the main function.