Add tests for federated SPARQL queries between the curies mapping service and popular triplestores #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice and popular triplestores properly work. Triplestores need to be deployed locally before running the tests with docker compose, if the triplestores are not deployed the tests for federated queries will be ignored. Added: - a docker-compose.yml to deploy the bioregistry, blazegraph and virtuoso - a resources/ folder in tests which contains the Dockerfile for the curies mapping service used for testing, and an init script for the triplestores - a step to start and init the triplestores in the gh action for testing - instructions to start the triplestores with docker compose in the readme - a tests/test_sparql.py file with 4 tests of federated queries using `SERVICE`: from virtuoso to curies, from blazegraph to curies, from curies to virtuoso, from curies to blazegraph
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 501 501
Branches 104 102 -2
=========================================
Hits 501 501
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthoyt
reviewed
Apr 13, 2023
…e is still failing due to an issue when extracting the sparql vars
cthoyt
reviewed
Apr 14, 2023
cthoyt
reviewed
Apr 14, 2023
| blazegraph: | ||
| image: metaphacts/blazegraph-basic:2.2.0-20160908.003514-6-jetty9.4.44-jre8-45dbfff | ||
| ports: | ||
| - 8889:8080 |
There was a problem hiding this comment.
is there a reason we can't just use the default ports for each service as we expose outside of docker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check if federated queries between the curies mapping service and popular triplestores properly work.
Triplestores need to be deployed locally before running the tests with docker compose, if the triplestores are not deployed the tests for federated queries will be skipped
Added:
docker-compose.ymlto deploy the bioregistry, blazegraph and virtuosoresources/folder in tests which contains the Dockerfile for the curies mapping service used for testing, and an init script for the triplestoresSERVICE: from virtuoso to curies, from blazegraph to curies, from curies to virtuoso, from curies to blazegraph