Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for evaluating predictions #12

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 168 additions & 0 deletions src/semra/evaluate_prediction.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,168 @@
import itertools as itt
import logging
from collections import defaultdict
from collections.abc import Iterable
from typing import TYPE_CHECKING

Check warning on line 5 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L1-L5

Added lines #L1 - L5 were not covered by tests

import click
from tqdm import tqdm

Check warning on line 8 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L7-L8

Added lines #L7 - L8 were not covered by tests

from semra.api import assemble_evidences, get_index
from semra.io import from_pyobo
from semra.rules import EXACT_MATCH, LEXICAL_MAPPING
from semra.struct import Mapping, MappingSet, Reference, SimpleEvidence

Check warning on line 13 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L10-L13

Added lines #L10 - L13 were not covered by tests

if TYPE_CHECKING:
import gilda

logger = logging.getLogger(__name__)

Check warning on line 18 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L18

Added line #L18 was not covered by tests


def _get_v1(positive_set, negative_set, predicted_set):
tp = len(positive_set.intersection(predicted_set)) # true positives
fp = len(negative_set.intersection(predicted_set)) # false positives
fn = len(positive_set - predicted_set) # false negatives
tn = len(negative_set - predicted_set) # true negatives
return tp, fp, fn, tn

Check warning on line 26 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L21-L26

Added lines #L21 - L26 were not covered by tests


def evaluate_predictions(

Check warning on line 29 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L29

Added line #L29 was not covered by tests
*,
positive: Iterable[Mapping],
negative: Iterable[Mapping],
predicted: Iterable[Mapping],
tag: str | None = None,
):
"""Evaluate predicted mappings using ground truth positive and negative mappings."""
positive_index = get_index(positive, progress=False)
negative_index = get_index(negative, progress=False)
predicted_index = get_index(predicted, progress=False)

Check warning on line 39 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L37-L39

Added lines #L37 - L39 were not covered by tests

positive_set = set(positive_index)
negative_set = set(negative_index)
predicted_set = set(predicted_index)

Check warning on line 43 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L41-L43

Added lines #L41 - L43 were not covered by tests

tp, fp, fn, tn = _get_v1(positive_set, negative_set, predicted_set)

Check warning on line 45 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L45

Added line #L45 was not covered by tests

predicted_only = len(predicted_set - positive_set - negative_set)
union_len = len(positive_set.union(predicted_set).union(negative_set))

Check warning on line 48 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L47-L48

Added lines #L47 - L48 were not covered by tests

msg = f"union={union_len:,}, intersection={tp:,}, curated={fn:,}, predicted={predicted_only:,}"

Check warning on line 50 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L50

Added line #L50 was not covered by tests
if tag is not None:
msg = f"[{tag}] {msg}"
logger.info(msg)

Check warning on line 53 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L52-L53

Added lines #L52 - L53 were not covered by tests

accuracy = (tp + tn) / (tp + tn + fp + fn)
recall = tp / (tp + fn)
precision = tp / (tp + fp)
f1 = 2 * tp / (2 * tp + fp + fn)
completion = 1 - predicted_only / len(predicted_set)

Check warning on line 59 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L55-L59

Added lines #L55 - L59 were not covered by tests

# what is the percentage of curated examples that are positive?
# positive_percentage = len(positive_set) / (len(positive_set) + len(negative_set))
return completion, accuracy, precision, recall, f1

Check warning on line 63 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L63

Added line #L63 was not covered by tests


def _index_text(grounder: "gilda.Grounder") -> dict[str, list["gilda.Term"]]:
dd = defaultdict(list)

Check warning on line 67 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L66-L67

Added lines #L66 - L67 were not covered by tests
for terms in grounder.entries.values():
for term in terms:
dd[term.text].append(term)
return dict(dd)

Check warning on line 71 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L70-L71

Added lines #L70 - L71 were not covered by tests


def _grounder_to_mappings(grounders: dict[str, "gilda.Grounder"]) -> Iterable[tuple["gilda.Term", "gilda.Term", float]]:

Check warning on line 74 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L74

Added line #L74 was not covered by tests
terms = {prefix: _index_text(grounder) for prefix, grounder in tqdm(grounders.items(), desc="Indexing texts")}
for (p1, g1), (p2, _g2) in tqdm(
itt.combinations(grounders.items(), 2), unit_scale=True, desc="Generating mappings"
):
text_to_terms = terms[p2]

Check warning on line 79 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L79

Added line #L79 was not covered by tests
for text, terms in tqdm(text_to_terms.items(), unit_scale=True, desc=f"{p1}-{p2} lexical"):
scored_matches = g1.ground(text)

Check warning on line 81 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L81

Added line #L81 was not covered by tests
# there are lots of ways to do this, now we do all-by-all
for subject_term, scored_match in itt.product(terms, scored_matches):
yield subject_term, scored_match.term, scored_match.score

Check warning on line 84 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L84

Added line #L84 was not covered by tests


#: A default confidence for mappings generated by Gilda
GILDA_CONFIDENCE = 0.9

Check warning on line 88 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L88

Added line #L88 was not covered by tests


def grounder_to_mappings(grounders: dict[str, "gilda.Grounder"]) -> list[Mapping]:
prefix_list_str = ", ".join(sorted(grounders))
mapping_set = MappingSet(name=f"Gilda predicted mappings for {prefix_list_str}", confidence=GILDA_CONFIDENCE)
mappings = []

Check warning on line 94 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L91-L94

Added lines #L91 - L94 were not covered by tests
for subject_term, object_term, confidence in _grounder_to_mappings(grounders):
mapping = Mapping(

Check warning on line 96 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L96

Added line #L96 was not covered by tests
s=Reference(prefix=subject_term.db, identifier=subject_term.id),
p=EXACT_MATCH,
o=Reference(prefix=object_term.db, identifier=object_term.id),
evidence=[SimpleEvidence(justification=LEXICAL_MAPPING, mapping_set=mapping_set, confidence=confidence)],
)
mappings.append(mapping)
mappings = assemble_evidences(mappings, progress=False)
return mappings

Check warning on line 104 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L102-L104

Added lines #L102 - L104 were not covered by tests


@click.command()
def main():
import pyobo.gilda_utils
import pystow
from tabulate import tabulate

Check warning on line 111 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L107-L111

Added lines #L107 - L111 were not covered by tests

from semra.api import infer_reversible, keep_prefixes
from semra.io import from_sssom, write_sssom
from semra.sources import from_biomappings_negative, get_biomappings_positive_mappings, get_clo_mappings

Check warning on line 115 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L113-L115

Added lines #L113 - L115 were not covered by tests

positive_mappings = get_biomappings_positive_mappings()
positive_mappings = infer_reversible(positive_mappings, progress=False)
click.echo(f"Got {len(positive_mappings):,} positive mappings")

Check warning on line 119 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L117-L119

Added lines #L117 - L119 were not covered by tests

negative_mappings = from_biomappings_negative()
negative_mappings = infer_reversible(negative_mappings, progress=False)
click.echo(f"Got {len(negative_mappings):,} negative mappings")

Check warning on line 123 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L121-L123

Added lines #L121 - L123 were not covered by tests

rows = []
mesh_grounder = pyobo.gilda_utils.get_grounder("mesh", versions="2023")

Check warning on line 126 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L125-L126

Added lines #L125 - L126 were not covered by tests
for prefix in sorted(["chebi", "maxo", "cl", "doid", "go", "uberon", "vo", "clo"]):
path = pystow.join("semra", "evaluation_prediction", name=f"evaluation_prediction_sample_{prefix}.tsv")

Check warning on line 128 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L128

Added line #L128 was not covered by tests

if path.is_file():
predicted_mappings = from_sssom(path, mapping_set_name="gilda predictions")

Check warning on line 131 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L131

Added line #L131 was not covered by tests
else:
grounders = {"mesh": mesh_grounder, prefix: pyobo.gilda_utils.get_grounder(prefix)}
predicted_mappings = grounder_to_mappings(grounders)
click.echo(f"Got {len(predicted_mappings):,} predicted mappings")
predicted_mappings = infer_reversible(predicted_mappings, progress=False)
write_sssom(predicted_mappings, path)

Check warning on line 137 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L133-L137

Added lines #L133 - L137 were not covered by tests

if prefix == "clo":
ontology_mappings = get_clo_mappings()
ontology_mappings = keep_prefixes(ontology_mappings, [prefix, "mesh"], progress=False)

Check warning on line 141 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L140-L141

Added lines #L140 - L141 were not covered by tests
else:
ontology_mappings = from_pyobo(prefix, "mesh")
ontology_mappings = infer_reversible(ontology_mappings, progress=False)
click.echo(f"[{prefix}] got {len(ontology_mappings):,} mappings from the ontology")

Check warning on line 145 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L143-L145

Added lines #L143 - L145 were not covered by tests

positive_mappings_subset = keep_prefixes(positive_mappings, [prefix, "mesh"], progress=False)
negative_mappings_subset = keep_prefixes(negative_mappings, [prefix, "mesh"], progress=False)
evaluation_row = evaluate_predictions(

Check warning on line 149 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L147-L149

Added lines #L147 - L149 were not covered by tests
positive=itt.chain(positive_mappings_subset, ontology_mappings),
negative=negative_mappings_subset,
predicted=predicted_mappings,
tag=prefix,
)
rows.append((f"[{prefix}](https://bioregistry.io/{prefix})", *evaluation_row))

Check warning on line 155 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L155

Added line #L155 was not covered by tests

click.echo(

Check warning on line 157 in src/semra/evaluate_prediction.py

View check run for this annotation

Codecov / codecov/patch

src/semra/evaluate_prediction.py#L157

Added line #L157 was not covered by tests
tabulate(
rows,
headers=["prefix", "completion", "accuracy", "precision", "recall", "f1"],
floatfmt=".1%",
tablefmt="github",
)
)


if __name__ == "__main__":
main()
2 changes: 1 addition & 1 deletion src/semra/io.py
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def _from_df(

def from_pyobo(prefix: str, target_prefix: str | None = None, *, standardize: bool = False, **kwargs) -> list[Mapping]:
if target_prefix:
return _from_pyobo_pair(prefix, target_prefix, standardize=standardize, **kwargs)
return _from_pyobo_pair(prefix, target_prefix, **kwargs)
return _from_pyobo_prefix(prefix, standardize=standardize, **kwargs)


Expand Down
Loading