Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove RBApy until it can be added back via PyPI #153

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

jcschaff
Copy link
Member

What new features does this PR implement?
remove RBApy dependency as it prevented us from publishing to PyPI, expand to Python 3.9, 3.10, 3.11

What bugs does this PR fix?
could not publish biosimulators_utils to PyPI (we were using it from source via a github branch install).

How have you tested this PR?
removed failing tests related to RBA
skipped failing tests related to publication citation queries - too many timeouts.

@jcschaff jcschaff self-assigned this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (e02d1f5) to head (f0a39e2).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #153      +/-   ##
==========================================
- Coverage   90.87%   88.81%   -2.07%     
==========================================
  Files          89       89              
  Lines        9610     9610              
==========================================
- Hits         8733     8535     -198     
- Misses        877     1075     +198     
Flag Coverage Δ
unittests 88.81% <100.00%> (-2.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jcschaff jcschaff merged commit c3219f0 into dev Sep 18, 2024
10 of 11 checks passed
@jcschaff jcschaff deleted the reconcile-rbapy branch September 18, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant