Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILDING_DETAILS.md: extra packages section updates and fixes #141

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

KanjiMonster
Copy link
Contributor

The build extra packages section describes how to add packages to the image, so rename the section header accordingly, and add a section describing how to build individual packages to install on a running system.

While at it, remove the $ prefixes from the shell section to align it to all other sections whe have, and capitalize Yocto.

@KanjiMonster KanjiMonster force-pushed the jogo_fix_update_extra_packages branch from 7e95128 to 3cbeed6 Compare January 10, 2025 11:01
Copy link
Contributor

@ideaship ideaship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KanjiMonster
Copy link
Contributor Author

What's missing (as a future exercise): description of package vs recipe (as bitbake takes recipe names, not package names), and how to find out what the recipe is named for a certain package. And maybe a link to the OpenEmbedded recipe index.

Base automatically changed from jogo_always_machine to main January 10, 2025 12:10
We don't  use $ in any other example commands, so drop them from the
example here as well.

Signed-off-by: Jonas Gorski <[email protected]>
"Building additional yocto packages" doesn't just build them, but
actually includes them in the image, so update the heading to signify
that.

Signed-off-by: Jonas Gorski <[email protected]>
Yocto is always capitalized, so we should follow that.

Signed-off-by: Jonas Gorski <[email protected]>
Add a decription on how to build additional packages and how to install
them on a running switch.

Signed-off-by: Jonas Gorski <[email protected]>
@KanjiMonster KanjiMonster force-pushed the jogo_fix_update_extra_packages branch from 3cbeed6 to 50c2365 Compare January 10, 2025 12:14
@KanjiMonster KanjiMonster marked this pull request as ready for review January 10, 2025 12:15
@KanjiMonster KanjiMonster marked this pull request as draft January 10, 2025 12:15
Adding missing whitespace to the beginning of the IMAGE_INSTALL:append
section, to avoid package names being merged together.

Signed-off-by: Jonas Gorski <[email protected]>
@KanjiMonster KanjiMonster marked this pull request as ready for review January 10, 2025 12:18
@KanjiMonster
Copy link
Contributor Author

Found and fixed one additional small issue.

@KanjiMonster KanjiMonster requested a review from ideaship January 10, 2025 12:18
them by passing them via `--target` to kas:

```shell
KAS_MACHINE=generic-x86-64 kas build --target lldpd bisdn-linux.yaml -- --runall=do_package_write_ipk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
KAS_MACHINE=generic-x86-64 kas build --target lldpd bisdn-linux.yaml -- --runall=do_package_write_ipk
KAS_MACHINE=generic-x86-64 kas-container build --target lldpd bisdn-linux.yaml -- --runall=do_package_write_ipk

We have a separate section on building without containers, the other examples should use kas-container. I realize that I accidentally introduced an example with kas as well, I can fix that or you can add it to this PR, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants