onie-tools: update upgrade note to current behavior #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now retain a lot of configuration data, so fix the note to state that and point to further details. Signed-off-by: Jonas Gorski <[email protected]>
jklare
reviewed
Oct 11, 2021
| @@ -31,8 +31,7 @@ This shows an example usage: | |||
| onie-bisdn-upgrade http://example_webserver.com/onie/onie-bisdn-agema-ag7648.bin | |||
| ``` | |||
|
|
|||
| **Note**: All data is deleted during the upgrade process except for configuration files in /etc/systemd/network/ that apply on interfaces named `enp*`. | |||
| {: .label .label-yellow } | |||
| **Note**: All data except certain configuration data is deleted during upgrade. See [Backup files/folders across installations](getting_started/install_bisdn_linux.md#backup-filesfolders-across-installations) for details on which configuration files are retained and how to control the behavior. | |||
There was a problem hiding this comment.
Suggested change
| **Note**: All data except certain configuration data is deleted during upgrade. See [Backup files/folders across installations](getting_started/install_bisdn_linux.md#backup-filesfolders-across-installations) for details on which configuration files are retained and how to control the behavior. | |
| **Note**: During an upgrade, everything except for certain configuration data will be overwritten. See [Backup files/folders across installations](getting_started/install_bisdn_linux.md#backup-filesfolders-across-installations) for details on which configuration files are retained and how to control the behavior. |
There was a problem hiding this comment.
Hm, somehow completely missed/forgot about this.
IMHO this may leave the wrong impression that only stuff being in the image is being overwritten, and files added by the user may be left intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now retain a lot of configuration data, so fix the note to state that
and point to further details.
Signed-off-by: Jonas Gorski [email protected]