installer: add a naive systemd service state backup and restore #278
+134
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If for whatever reason the old system's system-backup.txt or user-backup.txt are missing, don't fail the installation. Signed-off-by: Jonas Gorski <[email protected]>
Add support for backing up and restoring explicitly disabled and enabled services by checking their symlinks and restoring or removing them when applying the backup. It does naive enabled/disabled services heuristic: - if the .preset does not say enabled, and there is a symlink in multi-user.target.wants, recreate the symink on restore - if the .preset says enabled, and there was no symlink in multi-user.target.wants, remove the symlink on restore Additionally, it only checks certain services: - Skip any oneshot services (these are expected to be disabled with enabled preset after first boot) - Skip any services not targeting multi-user It does support parameterized services though, as supported by frr (via frr@something). This allows e.g. docker to continue to be enabled after an update to a newer version. It should now also keep the choice of baseboxd vs ryu on upgrade (untested though). Signed-off-by: Jonas Gorski <[email protected]>
KanjiMonster
force-pushed
the
jogo_installer_systemd_services
branch
from
8bc762f to
12b82da
Compare
jklare
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for backing up and restoring explicitly disabled and enabled
services by checking their symlinks and restoring or removing them when
applying the backup.
It does naive enabled/disabled services heuristic:
multi-user.target.wants, recreate the symink on restore
multi-user.target.wants, remove the symlink on restore
Additionally, it only checks certain services:
enabled preset after first boot)
It does support parameterized services though, as supported by frr (via
frr@something).
This allows e.g. docker to continue to be enabled after an update to a
newer version. It should now also keep the choice of baseboxd vs ryu on
upgrade (untested though).