netif_utils: fix speeds > 65G #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethtool_cmd.speed is a 16 bit value, so the highest representable speed is 65.535 MB/s. For higher speeds, the upper bits are stored in cmd.speed_hi. But since mstpd was only looking at speed, effectively the speed used was modulo 65536. This broke cost calculation, as a 200G link was now considered a 34.4G link, so its cost rose from expected 100 to 580. Fix this by using the provided helper, ethtool_cmd_speed(). Signed-off-by: Jonas Gorski <[email protected]>
KanjiMonster
force-pushed
the
jogo_int_fix_hi_speed
branch
from
2ddbe40 to
c5d42e2
Compare
rubensfig
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethtool_cmd.speed is a 16 bit value, so the highest representable speed is 65.535 MB/s. For higher speeds, the upper bits are stored in cmd.speed_hi.
But since mstpd was only looking at speed, effectively the speed used was modulo 65536. This broke cost calculation, as a 200G link was now considered a 34.4G link, so its cost rose from expected 100 to 580.
Fix this by using the provided helper, ethtool_cmd_speed().