UI: Create offer flow #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if Settings.firstLaunch is true. Onboarding screen will be shown. - On viewing all slides in Onboarding screen, Settings.firstLanuch is persisted to false - Multi screen wizard transitions. Replaced slide with fadeIn/Out - Multi screen wizard Topbar.Progressbar fixed - Rounded btc display to 8 decimals (KMP logic. Platform specific implementation
- BispGap - Button - Custom text component - CurrencyProfileCard - Selectable - Multiscreen wizard - Can make use of both Scroll and Static Scaffolds now. Whichever screen needs to use LazyColumn, can now maje use of static - Btc - sats display (partial)
|
rebased against latest main changes |
Closed
rodvar
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Great stuff @nostrbuddha
I've created the following issues to be work separately one-by-one.
- Onboarding: Navigation logic #109
- Create Offer / Take Offer: currency list should not show offers data #110
- Take Offer: cards not constrained #111
- Currencies List: Search bar filter #112
Please comment on the ones you would like to tackle yourself and create one PR per issue or one PR that caters for several of them please 🙏 - what is most comfortable for you.
...esentation/src/commonMain/kotlin/network/bisq/mobile/presentation/ui/components/atoms/Gap.kt
Show resolved
Hide resolved
...nMain/kotlin/network/bisq/mobile/presentation/ui/components/molecules/RangeAmountSelector.kt
Show resolved
Hide resolved
shared/domain/src/commonMain/kotlin/network/bisq/mobile/domain/data/model/Settings.kt
Show resolved
Hide resolved
rodvar
added a commit
that referenced
this pull request
Feb 5, 2025
* Persistance logic - if Settings.firstLaunch is true. Onboarding screen will be shown. - On viewing all slides in Onboarding screen, Settings.firstLanuch is persisted to false - Multi screen wizard transitions. Replaced slide with fadeIn/Out - Multi screen wizard Topbar.Progressbar fixed - Rounded btc display to 8 decimals (KMP logic. Platform specific implementation * Create Offer - 2 screens and various minor updates; - BispGap - Button - Custom text component - CurrencyProfileCard - Selectable - Multiscreen wizard - Can make use of both Scroll and Static Scaffolds now. Whichever screen needs to use LazyColumn, can now maje use of static - Btc - sats display (partial) * - Create offer UI 2/3 * - GettingStarted Interface * - delete unnecessary appleMain dir --------- Co-authored-by: Rodrigo Varela <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All trade screens are covered just enough, so functional integration can start to happen.
Individual screen elements can be improved much.