Feature/account profile settings #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rodvar
commented
Dec 16, 2024
rodvar
commented
- Implementation of 10a and 10b for Account #51
- done necessary adaptations on userProfileFacade to be able to access the profile details
- statement/tradeTerms and lastActivity are handled using the repository pattern
- fully tested on 3 apps - on clients an endpoint / modification is needed therefore most values will show as "N/A"
- handy utils for displaying dates
- applied refactors recommended in previous PR
…for general usage
…id crash on client, seems trusted node call not yet implemented
- settings screen implementation for UserProfile UX best practices with header + scroll + footer
- implementation for save profile, using incorrect spinner image for now
|
@nostrbuddha please review |
|
merging for productivity purposes, PR still pending review from Buddha will work on his comments if any on next contribs. |
rodvar
added a commit
that referenced
this pull request
Feb 5, 2025
* - initial layout for User Profile based on designs * - implement requested refactor on previous PR review * - use bisqScroll layout + add leaft to breadcrum navigation * - adaptat userprofilefacade to share a bisq-mobile-compatible model for general usage * - implementation on profile age + adaptations on user profile to avoid crash on client, seems trusted node call not yet implemented * - setup editable/non editable textfields on settings, added botid and profileid * - allow bisqScroll layout to modify modifier with callback - settings screen implementation for UserProfile UX best practices with header + scroll + footer * - last user activity implementation * - hide delete profile as its not part of the mvp - implementation for save profile, using incorrect spinner image for now * - final touches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.