Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/home redesign #143

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Conversation

rodvar
Copy link
Collaborator

@rodvar rodvar commented Dec 27, 2024

  • Implementation for Home: User interactions & data #97
  • provided generic way of navigating to URL using default browser and applied to home navigations
  • Same for blocking UI, with examples on avatar and this home screen. This fixes double-tap UI issues
  • Start Trading takes the user to the Buy/Sell trading screen
  • Applied new desing to home screen
  • fix breadcrum navigation bug on leaf click

@rodvar rodvar self-assigned this Dec 27, 2024
@rodvar rodvar force-pushed the feature/home_redesign branch from 1cb39fc to 26ee319 Compare December 28, 2024 04:47
@nostrbuddha
Copy link
Contributor

nostrbuddha commented Jan 1, 2025

One issue. This happens at times, not always.

  1. I click on 'Learn more' to open the URL in external browser (Chrome here).
  2. Press hardware back button to get back to Bisq app.
  3. 'Start trading' is now disabled.
Start.trading.-.Disabled.-.Shorter.mov

Tested and happens in both androidNode and androidClient.

@nostrbuddha
Copy link
Contributor

  1. 'Published Profiles' count is pending from 'domain/services'?

  2. isInteractive is a great idea :-)
    Just a suggestion to improve it further. Rather than enabling/disabling UI controls, the logic can be moved to BisqScroll/StaticLayout, which observes for this state change. And when isInteractive is set to true, it render a transparent box over the whole screen, which captures all user input's, thus disabling the controls below. I can do it it next PR. Let me know.

@rodvar
Copy link
Collaborator Author

rodvar commented Jan 6, 2025

@nostrbuddha buddha thanks for taking the time of reviewing my PR and spotting that bug - well done 💪
I'll fix it in a commit in a bit.

Regarding your questions above:

  1. correct
  2. I think that's a great improvement, so we don't have to apply the verification on every single interactive button/link. Happy to get that in in your next PR! We just need to make sure that it only disables the UI whilst processing specific stuff (as bugs like the ones you discovered above are not nice for the UX 😆 ).

Cheers!

@rodvar rodvar force-pushed the feature/home_redesign branch from 26ee319 to 3c3d285 Compare January 6, 2025 00:42
@rodvar
Copy link
Collaborator Author

rodvar commented Jan 6, 2025

branch rebased

…i thread

 - fix major bug: presenters loosing root link on first destroy
@rodvar
Copy link
Collaborator Author

rodvar commented Jan 6, 2025

@nostrbuddha please have a look at my commit and review again when you have some time. You helped spotting a major issue that would certainly bring problems in the future so great we tackled it now ;) cheers!

@rodvar rodvar merged commit 865c80e into bisq-network:main Jan 6, 2025
1 check passed
@rodvar rodvar deleted the feature/home_redesign branch January 6, 2025 04:22
@nostrbuddha
Copy link
Contributor

2. I think that's a great improvement, so we don't have to apply the verification on every single interactive button/link. Happy to get that in in your next PR! We just need to make sure that it only disables the UI whilst processing specific stuff (as bugs like the ones you discovered above are not nice for the UX 😆 ).
  • Yes. I will do this in the other pending PR, tomorrow night.

rodvar added a commit that referenced this pull request Feb 5, 2025
* - implemented default trusted node changes + multiplatform navigate to url with handy base presenter method to reuse

* - fix navigateToUrl in iOS

* - Implemented enable/disable interactivity of UI in a generalized way with examples in home screen and avatar + node specific getting started texts

* - fix bug on breadcrum navigation generating multiple leafs connections

* - connected offers online with facade.

* - robust implementation for enable/disable interactivity to run on ui thread
 - fix major bug: presenters loosing root link on first destroy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants