-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/home redesign #143
Conversation
rodvar
commented
Dec 27, 2024
•
edited
Loading
edited
- Implementation for Home: User interactions & data #97
- provided generic way of navigating to URL using default browser and applied to home navigations
- Same for blocking UI, with examples on avatar and this home screen. This fixes double-tap UI issues
- Start Trading takes the user to the Buy/Sell trading screen
- Applied new desing to home screen
- fix breadcrum navigation bug on leaf click
1cb39fc
to
26ee319
Compare
One issue. This happens at times, not always.
Start.trading.-.Disabled.-.Shorter.movTested and happens in both androidNode and androidClient. |
|
@nostrbuddha buddha thanks for taking the time of reviewing my PR and spotting that bug - well done 💪 Regarding your questions above:
Cheers! |
…to url with handy base presenter method to reuse
…y with examples in home screen and avatar + node specific getting started texts
26ee319
to
3c3d285
Compare
branch rebased |
…i thread - fix major bug: presenters loosing root link on first destroy
@nostrbuddha please have a look at my commit and review again when you have some time. You helped spotting a major issue that would certainly bring problems in the future so great we tackled it now ;) cheers! |
|
* - implemented default trusted node changes + multiplatform navigate to url with handy base presenter method to reuse * - fix navigateToUrl in iOS * - Implemented enable/disable interactivity of UI in a generalized way with examples in home screen and avatar + node specific getting started texts * - fix bug on breadcrum navigation generating multiple leafs connections * - connected offers online with facade. * - robust implementation for enable/disable interactivity to run on ui thread - fix major bug: presenters loosing root link on first destroy