Add numDaysAfterRedactingTradeData #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_AFTER_REDACTING_TRADE_DATA - [401fc11] fix compilation error of android node - [2c231f5] remove unused files - [75f9c1a] Add numDaysAfterRedactingTradeData to be in sync with bisq-network/bisq2#3134
rodvar
force-pushed
the
feature/add_num_days_redacting_bisq2_sec
branch
from
f408fb3 to
d4af3e1
Compare
|
@HenrikJannsen I connected the components with the value coming from the network (node and clients), and made it available for the general settings to display (that's hidden at the moment @nostrbuddha is working on it). Could you please review and let me know if there is a specific application/validation we need to do with that network number? |
HenrikJannsen
suggested changes
Feb 7, 2025
| private val _numDaysAfterRedactingTradeData: MutableStateFlow<Int> = MutableStateFlow(90) | ||
| override val numDaysAfterRedactingTradeData: StateFlow<Int> get() = _numDaysAfterRedactingTradeData | ||
| override suspend fun setNumDaysAfterRedactingTradeData(days: Int) { | ||
| // Not applicable for xClients |
There was a problem hiding this comment.
We should implement the API call as with other properties
|
@HenrikJannsen just checked, this is the UI you are referring to: I need the settings stuff for that and buddha is working on it, I'll merge this PR and create an issue to do the UI and allow edit (API impl) |
|
See also the controller in Bisq 2 for the validation of the min/max values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of -> #174