Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/repositories architecture #41

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Feature/repositories architecture #41

merged 3 commits into from
Nov 14, 2024

Conversation

rodvar
Copy link
Collaborator

@rodvar rodvar commented Nov 14, 2024

  • Implementation for Shared Repositories Architecture #40
  • change the code examples to use the architecture
  • fix coin initalization for iOS to include presentation module as well
  • after merging this PR composable views can leverage field injection using koinInject as shown in the current composable App() view
  • tested on the 3 apps

@rodvar
Shared observable repository data models setup
a7d9540 
 - define interface and abstractions
 - implementation of Single object repository allowing for persistance
   (not implemented yet)
 - examples of usages replacing current greeting in basic UI
 - implementation for androidNode, and both clients
 - showcasing a mechanism to link a specific field of the model we want
   to observe in the presenter for the view (as the view requests it)
@rodvar
- field Koin injection for views (important for nested views)
c00b5ae
@rodvar
- adjustments for iOS
b5e8031
@rodvar rodvar self-assigned this Nov 14, 2024
@nostrbuddha
Copy link
Contributor

Thanks for showing how koin/DI is done!

@rodvar
Copy link
Collaborator Author

rodvar commented Nov 14, 2024

Thanks for showing how koin/DI is done!

there is still some stuff to improve but we'll do it soon! ;) thanks for reviewing the code @nostrbuddha !

@rodvar rodvar merged commit 7432472 into bisq-network:main Nov 14, 2024
1 check passed
@rodvar rodvar deleted the feature/repositories_architecture branch November 14, 2024 00:38
rodvar added a commit that referenced this pull request Feb 5, 2025
@rodvar
Feature/repositories architecture (#41)
4f1db35 
* Shared observable repository data models setup

 - define interface and abstractions
 - implementation of Single object repository allowing for persistance
   (not implemented yet)
 - examples of usages replacing current greeting in basic UI
 - implementation for androidNode, and both clients
 - showcasing a mechanism to link a specific field of the model we want
   to observe in the presenter for the view (as the view requests it)

* - field Koin injection for views (important for nested views)

* - adjustments for iOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rodvar rodvar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodvar @nostrbuddha