Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallets/bitcoind submodule #2984

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Nov 6, 2024

We use the same bitcoind regtest module in Bisq 1 and 2. To avoid
duplicate code I moved the bitcoind module to its own repository.

@alvasw
Copy link
Contributor Author

alvasw commented Nov 6, 2024

Please inform all devs in the matrix channel after merging this change as some could be confused when they pull the changes.

@alvasw alvasw marked this pull request as draft November 6, 2024 19:56
@alvasw alvasw force-pushed the add_bitcoind_submodule branch from a06bfc5 to 5eb84fe Compare November 6, 2024 19:59
@alvasw alvasw marked this pull request as ready for review November 6, 2024 20:00
@alvasw alvasw marked this pull request as draft November 6, 2024 20:01
@alvasw alvasw force-pushed the add_bitcoind_submodule branch 2 times, most recently from 2d266fb to ca8af22 Compare November 6, 2024 20:39
We use the same bitcoind regtest module in Bisq 1 and 2. To avoid
duplicate code I moved the bitcoind module to its own repository.
@alvasw alvasw force-pushed the add_bitcoind_submodule branch from ca8af22 to 98448be Compare November 6, 2024 20:41
@alvasw alvasw marked this pull request as ready for review November 6, 2024 20:43
@HenrikJannsen HenrikJannsen merged commit 45f8203 into bisq-network:main Nov 7, 2024
15 checks passed
@HenrikJannsen HenrikJannsen added this to the 2.1.3 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants