Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Improvements to symbol visibility logic on Windows (attempt 3) #1367

Merged
merged 5 commits into from
Jul 3, 2023
Merged

build: Improvements to symbol visibility logic on Windows (attempt 3) #1367

merged 5 commits into from
Jul 3, 2023

Commits on Jul 3, 2023

  1. build: Introduce SECP256K1_STATIC macro for Windows users 

    It is a non-Libtool-specific way to explicitly specify the user's
intention to consume a static `libseck256k1`.

This change allows to get rid of MSVC linker warnings LNK4217 and
LNK4286. Also, it makes possible to merge the `SECP256K1_API` and
`SECP256K1_API_VAR` into one.
    @hebasto
    hebasto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ae9db95 View commit details
    Browse the repository at this point in the history

  2. refactor: Replace SECP256K1_API_VAR with SECP256K1_API

    @hebasto
    hebasto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    9f1b190 View commit details
    Browse the repository at this point in the history

  3. build: Introduce SECP256k1_DLL_EXPORT macro 

    This change provides a way to build a shared library that is not tired
to the Libtool-specific `DLL_EXPORT` macro.
    @hebasto
    hebasto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0196e8a View commit details
    Browse the repository at this point in the history

  4. build: Add extensive docs on visibility issues

    @real-or-random @hebasto
    real-or-random authored and hebasto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    020bf69 View commit details
    Browse the repository at this point in the history

  5. ci: Add task for static library on Windows + CMake

    @hebasto
    hebasto committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    c6cd2b1 View commit details
    Browse the repository at this point in the history