ci, gha: Add Windows jobs based on Linux image #1398
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: 'Run in Docker with environment' | ||
| description: 'Run a command in a Docker container, while passing explicitly set environment variables into the container.' | ||
| inputs: | ||
| dockerfile: | ||
| description: 'A Dockerfile that defines an image' | ||
| required: true | ||
| tag: | ||
| description: 'A tag of an image' | ||
| required: true | ||
| command: | ||
| description: 'A command to run in a container' | ||
| required: true | ||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - uses: docker/setup-buildx-action@v2 | ||
| with: | ||
| # See: https://github.com/moby/buildkit/issues/3969. | ||
| driver-opts: | | ||
| network=host | ||
|
|
||
| - uses: docker/build-push-action@v4 | ||
| with: | ||
| context: . | ||
| file: ${{ inputs.dockerfile }} | ||
| tags: ${{ inputs.tag }} | ||
| load: true | ||
| cache-from: type=gha | ||
|
|
||
| - # Tell Docker to pass environment variables in `env` into the container. | ||
| run: > | ||
| docker run \ | ||
| $(echo '${{ toJSON(env) }}' | jq -r 'keys[] | "--env \(.) "') \ | ||
| --volume ${{ github.workspace }}:${{ github.workspace }} \ | ||
| --workdir ${{ github.workspace }} \ | ||
| ${{ inputs.tag }} bash -c "${{ inputs.command }}" | ||
| shell: bash |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,6 +42,82 @@ env: | |
| EXAMPLES: 'yes' | ||
|
|
||
| jobs: | ||
| docker_cache: | ||
| name: "Build Docker image" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v2 | ||
| with: | ||
| # See: https://github.com/moby/buildkit/issues/3969. | ||
| driver-opts: | | ||
| network=host | ||
|
|
||
| - name: Build container | ||
| uses: docker/build-push-action@v4 | ||
| with: | ||
| file: ./ci/linux-debian.Dockerfile | ||
| tags: linux-debian-image | ||
| cache-from: type=gha | ||
| cache-to: type=gha,mode=min | ||
|
|
||
| mingw_debian: | ||
| name: ${{ matrix.configuration.job_name }} | ||
| runs-on: ubuntu-latest | ||
| needs: docker_cache | ||
|
|
||
| env: | ||
| WRAPPER_CMD: 'wine' | ||
| WITH_VALGRIND: 'no' | ||
| ECDH: 'yes' | ||
| RECOVERY: 'yes' | ||
| SCHNORRSIG: 'yes' | ||
| ELLSWIFT: 'yes' | ||
| CTIMETESTS: 'no' | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| configuration: | ||
| - job_name: 'x86_64 (mingw32-w64): Windows (Debian stable, Wine)' | ||
| env_vars: | ||
| HOST: 'x86_64-w64-mingw32' | ||
| - job_name: 'i686 (mingw32-w64): Windows (Debian stable, Wine)' | ||
| env_vars: | ||
| HOST: 'i686-w64-mingw32' | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: CI script | ||
| env: ${{ matrix.configuration.env_vars }} | ||
| uses: ./.github/actions/run-in-docker-action | ||
| with: | ||
| dockerfile: ./ci/linux-debian.Dockerfile | ||
| tag: linux-debian-image | ||
| command: > | ||
| git config --global --add safe.directory ${{ github.workspace }} && | ||
| ./ci/ci.sh | ||
|
|
||
| - run: cat tests.log || true | ||
| if: ${{ always() }} | ||
| - run: cat noverify_tests.log || true | ||
| if: ${{ always() }} | ||
| - run: cat exhaustive_tests.log || true | ||
| if: ${{ always() }} | ||
| - run: cat ctime_tests.log || true | ||
| if: ${{ always() }} | ||
| - run: cat bench.log || true | ||
| if: ${{ always() }} | ||
| - run: cat config.log || true | ||
| if: ${{ always() }} | ||
| - run: cat test_env.log || true | ||
| if: ${{ always() }} | ||
| - name: CI env | ||
| run: env | ||
| if: ${{ always() }} | ||
|
There was a problem hiding this comment. use a yaml template to de-duplicate this? There was a problem hiding this comment. It is not supported for now, unfortunately. See: actions/runner#1182. |
||
|
|
||
| macos-native: | ||
| name: "x86_64: macOS Ventura" | ||
| # See: https://github.com/actions/runner-images#available-images. | ||
|
|
@@ -80,7 +156,7 @@ jobs: | |
|
|
||
| - name: CI script | ||
| env: ${{ matrix.env_vars }} | ||
| run: ./ci/ci.sh | ||
|
|
||
| - run: cat tests.log || true | ||
| if: ${{ always() }} | ||
|
|
||
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be refactored into an action? Or is this overkill?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case it won't show separated entries in the log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok yes, let's leave it like this for now.
(I'm not happy with this and it should be reworked in a separate PR. I had introduced this printing of files to make sure that we always have all logs, and I think that's a good idea in general. But it's not a good idea to pipe it only to files. We should pipe it to files but also keep stdout/stderr, e.g., using
tee. People get confused about this over and over because they can't find the error messages in the failing tasks etc.)