-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: quickstart in swift is now runnable #78
feat: quickstart in swift is now runnable #78
Conversation
Code looks good, so whatever way you decide to do this (project, no project, etc) is good w me- |
ok cool, I'll play around with a minimal xcode proj and see if that would make more sense |
This looks good to me too, you can close #82. I thought you were using some sort of script tool but looks like you're just using |
@thunderbiscuit looks like this is the direction the team wants to go The main open q left to fully address here is exactly how much xcode specific details to include in the instructions. I think we can outline that stuff and also mention that the actual code example is not an xcode project. That's what it currently does but we can iterate a little on that |
9350e27
to
34876cc
Compare
This still looks good (I'll give an ACK once merge conflicts are resolved) Just @ me to give me a heads up when conflicts resolved and I can ACK |
34876cc
to
33a1059
Compare
@reez ok conflicts resolved. However, I noticed that bdk-swift is still in beta...? so if that'll get updated soon maybe it'd be better to wait on this... but also I see no real reason to wait. just sayin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great thanks! @thunderbiscuit this is ready to merge |
No I'm not the only one who can merge here. Feel free to do so @reez! |
@thunderbiscuit for whatever reason I dont seem to have merge access when I'm looking, I could totally be missing something, but here's what it looks like in the GitHub web interface for me: |
Oh shoot sorry man I had assumed this would be a available as per the org's defaults. I added you now. |
If we do want to move forward with running swift examples as scripts like this, here's the updated quickstart
Matthew seems fine with it
@reez here's the updated version, only required minor changes from the basics.md you had