Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quickstart in swift is now runnable #78

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

riverKanies
Copy link
Contributor

If we do want to move forward with running swift examples as scripts like this, here's the updated quickstart

Matthew seems fine with it

@reez here's the updated version, only required minor changes from the basics.md you had

@reez
Copy link
Collaborator

reez commented Oct 29, 2024

Code looks good, so whatever way you decide to do this (project, no project, etc) is good w me-

@riverKanies
Copy link
Contributor Author

ok cool, I'll play around with a minimal xcode proj and see if that would make more sense

@riverKanies riverKanies marked this pull request as draft October 29, 2024 19:46
@notmandatory
Copy link
Member

This looks good to me too, you can close #82. I thought you were using some sort of script tool but looks like you're just using swift package init --type executable which seems a minimal way to get started.

@riverKanies riverKanies marked this pull request as ready for review October 30, 2024 18:12
@riverKanies
Copy link
Contributor Author

@thunderbiscuit looks like this is the direction the team wants to go

The main open q left to fully address here is exactly how much xcode specific details to include in the instructions. I think we can outline that stuff and also mention that the actual code example is not an xcode project. That's what it currently does but we can iterate a little on that

@reez
Copy link
Collaborator

reez commented Jan 21, 2025

This still looks good (I'll give an ACK once merge conflicts are resolved)

Just @ me to give me a heads up when conflicts resolved and I can ACK

@riverKanies riverKanies force-pushed the feature/swift-quickstart branch from 34876cc to 33a1059 Compare January 23, 2025 08:50
@riverKanies
Copy link
Contributor Author

@reez ok conflicts resolved.

However, I noticed that bdk-swift is still in beta...? so if that'll get updated soon maybe it'd be better to wait on this... but also I see no real reason to wait. just sayin

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reez ok conflicts resolved.

However, I noticed that bdk-swift is still in beta...? so if that'll get updated soon maybe it'd be better to wait on this... but also I see no real reason to wait. just sayin

ACK 33a1059

Yeah I say lets not wait either 👍

@riverKanies
Copy link
Contributor Author

great thanks!

@thunderbiscuit this is ready to merge
(I guess maybe you're the only one who merges on the book, was a bit confused about that)

@thunderbiscuit
Copy link
Member

No I'm not the only one who can merge here. Feel free to do so @reez!

@reez
Copy link
Collaborator

reez commented Jan 25, 2025

@thunderbiscuit for whatever reason I dont seem to have merge access when I'm looking, I could totally be missing something, but here's what it looks like in the GitHub web interface for me:
Screenshot 2025-01-25 at 12 09 55 PM

@thunderbiscuit
Copy link
Member

Oh shoot sorry man I had assumed this would be a available as per the org's defaults. I added you now.

@reez reez merged commit c0acb00 into bitcoindevkit:master Jan 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants