Skip to content

Commit

Permalink
feat(kube-state-metrics)!: remove resource VPA no longer available si…
Browse files Browse the repository at this point in the history
…nce v2.9.0

Signed-off-by: Benjamin <[email protected]>
  • Loading branch information
stucki-stuck committed Jan 31, 2025
1 parent 32912fd commit 442f5a7
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 13 deletions.
2 changes: 1 addition & 1 deletion bitnami/kube-state-metrics/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ maintainers:
name: kube-state-metrics
sources:
- https://github.com/bitnami/charts/tree/main/bitnami/kube-state-metrics
version: 4.3.4
version: 5.0.0
15 changes: 14 additions & 1 deletion bitnami/kube-state-metrics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ As an alternative, use one of the preset configurations for pod affinity, pod an
| `kubeResources.services` | Enable the `services` resource | `true` |
| `kubeResources.statefulsets` | Enable the `statefulsets` resource | `true` |
| `kubeResources.storageclasses` | Enable the `storageclasses` resource | `true` |
| `kubeResources.verticalpodautoscalers` | Enable the `verticalpodautoscalers` resource | `false` |
| `kubeResources.validatingwebhookconfigurations` | Enable the `validatingwebhookconfigurations` resource | `false` |
| `kubeResources.volumeattachments` | Enable the `volumeattachments` resource | `true` |
| `podSecurityContext.enabled` | Enabled kube-state-metrics pods' Security Context | `true` |
Expand Down Expand Up @@ -306,6 +305,20 @@ Find more information about how to deal with common errors related to Bitnami's

## Upgrading

### To 5.0.0

Removal of `kubeResources.verticalpodautoscalers` which no longer work since version `2.9.0` of kube-state-metrics. If you are using an older version and want to keep this metric, use the following configuration:

Check warning on line 310 in bitnami/kube-state-metrics/README.md

View workflow job for this annotation

GitHub Actions / markdown-linter

MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
```yaml

Check warning on line 311 in bitnami/kube-state-metrics/README.md

View workflow job for this annotation

GitHub Actions / markdown-linter

MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```yaml"]
rbac:
rules:
- apiGroups: ["autoscaling.k8s.io"]
resources:
- verticalpodautoscalers
verbs: ["list", "watch"]
extraArgs:
resources: verticalpodautoscalers
```

### To 4.3.0

This version introduces image verification for security purposes. To disable it, set `global.security.allowInsecureImages` to `true`. More details at [GitHub issue](https://github.com/bitnami/charts/issues/30850).
Expand Down
6 changes: 0 additions & 6 deletions bitnami/kube-state-metrics/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -169,12 +169,6 @@ rules:
- storageclasses
verbs: ["list", "watch"]
{{- end }}
{{- if .Values.kubeResources.verticalpodautoscalers }}
- apiGroups: ["autoscaling.k8s.io"]
resources:
- verticalpodautoscalers
verbs: ["list", "watch"]
{{- end }}
{{- if .Values.kubeResources.validatingwebhookconfigurations }}
- apiGroups: ["admissionregistration.k8s.io"]
resources:
Expand Down
3 changes: 0 additions & 3 deletions bitnami/kube-state-metrics/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,6 @@ spec:
{{- if .Values.kubeResources.storageclasses }}
- --resources=storageclasses
{{- end }}
{{- if .Values.kubeResources.verticalpodautoscalers }}
- --resources=verticalpodautoscalers
{{- end }}
{{- if .Values.kubeResources.validatingwebhookconfigurations }}
- --resources=validatingwebhookconfigurations
{{- end }}
Expand Down
2 changes: 0 additions & 2 deletions bitnami/kube-state-metrics/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ namespaces: ""
## @param kubeResources.services Enable the `services` resource
## @param kubeResources.statefulsets Enable the `statefulsets` resource
## @param kubeResources.storageclasses Enable the `storageclasses` resource
## @param kubeResources.verticalpodautoscalers Enable the `verticalpodautoscalers` resource
## @param kubeResources.validatingwebhookconfigurations Enable the `validatingwebhookconfigurations` resource
## @param kubeResources.volumeattachments Enable the `volumeattachments` resource
##
Expand Down Expand Up @@ -252,7 +251,6 @@ kubeResources:
services: true
statefulsets: true
storageclasses: true
verticalpodautoscalers: false
validatingwebhookconfigurations: false
volumeattachments: true
## Configure Pods Security Context
Expand Down

0 comments on commit 442f5a7

Please sign in to comment.