Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/rabbitmq] feat: ✨ Allow password updates #30615

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

javsalgar
Copy link
Contributor

Signed-off-by: Javier J. Salmerón García [email protected]

Description of the change

This PR allows updating passwords in the RabbitMQ chart. In order to not break existing deployments, this must be set using auth.updatePassword=true. In future majors, once this is mature enough, we could consider enabling it by default.

It also adds a documentation section in the README.md file.

Benefits

Better password management

Possible drawbacks

Unexpected corner cases

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Javier J. Salmerón García <[email protected]>
@github-actions github-actions bot added rabbitmq verify Execute verification workflow for these changes bitnami labels Nov 25, 2024
@github-actions github-actions bot requested a review from dgomezleon November 25, 2024 11:45
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javsalgar javsalgar merged commit d98aecc into main Nov 25, 2024
12 checks passed
@javsalgar javsalgar deleted the feature/rabbitmq-password-update branch November 25, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami rabbitmq solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants