[STEP-2064] Simplified validation #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothszabi
commented
Jan 7, 2025
| return config.internalValidation(false) | ||
| } | ||
|
|
||
| func (config *BitriseDataModel) internalValidation(full bool) ([]string, error) { |
There was a problem hiding this comment.
I kept the order of the field validation and did not group the ones which should be performed only in full mode under a big if statement. The reason is that the collected warnings with this ordering follows the the order of the fields appearing in the config yaml.
ofalvai
previously approved these changes
Jan 8, 2025
ofalvai
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MINOR version update
Context
This PR introduces a new internal minimal validation mode. This means that with the
runandtriggercommands the following config parts will not be validated:So everything needed for local execution (workflows, step bundles, app envs, containers) will still be validated.
Only the validation will be skipped for the above mentioned sections. The yaml still needs to be in a parseable state.