Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that non power-of-two lengths are valid #129

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarify that non power-of-two lengths are valid #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97cc9c8
Clairfy that non power-of-two lengths are valid
alanmcgovern Jun 9, 2022
05baa3d
Update beps/bep_0052.rst
alanmcgovern Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion beps/bep_0052.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,8 @@ to the leaf and piece layers. Index is the offset in hashes
of the first requested hash in the base layer.
Index MUST be a multiple of length, this includes zero.
Length is the number of hashes to include from the base layer.
Length MUST be equal-to-or-greater-than two and a power of two.
Length MUST be equal-to-or-greater-than two and a power of two unless it
gets truncated by the end of the layer.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mimicking

'request' messages contain an index, begin, and length. The last
two are byte offsets. Length is generally a power of two unless it
gets truncated by the end of a file. All current implementations use
2^14 (16 kiB), and close connections which request an amount greater than
that.

Length SHOULD NOT be greater than 512. Proof layers is the
number of ancestor layers to include. Note that the limits imposed on
index and length above mean that at-most one uncle hash is needed
Expand Down