Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that duplicated keys in bencode directory are not allowed #154

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Document that duplicated keys in bencode directory are not allowed #154

wants to merge 4 commits into from

Conversation

trim21
Copy link

@trim21 trim21 commented May 29, 2024 •
edited
Loading

#153

here d3:keyi1e3:keyi2ee or d3:keyi2e3:keyi1ee are same directory but can have different bencode content.

This may confusing info_hash generator. save torrent will result into different info_hash

the8472
the8472 reviewed May 29, 2024
View reviewed changes
beps/bep_0052.rst Outdated Show resolved Hide resolved
@trim21

This comment was marked as off-topic.

Sign in to view
@the8472
Copy link
Contributor

the8472 commented May 29, 2024

There's a makefile in the bep dir

jasonaowen added a commit to jasonaowen/bittorrent.org that referenced this pull request Jan 24, 2025
@jasonaowen
Merge PR bittorrent#154
14b7d54 
    Document that duplicated keys in bencode directory are not allowed

    bittorrent#153

    here d3:keyi1e3:keyi2ee or d3:keyi2e3:keyi1ee are same directory but
    can have different bencode content.

    This may confusing info_hash generator. save torrent will result
    into different info_hash

bittorrent#154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the8472 the8472 the8472 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trim21 @the8472