Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17948] Migrate export from generator legacy to generator core #13238

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

@djsmith85 djsmith85 commented Feb 4, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17948

📔 Objective

Migrate the usage of @bitwarden/generator-legacy to @bitwarden/generator-core

Functionality of generating a password for a password protected export stays the same, but uses the new credential-generator services instead.

Relates to #13208

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested review from a team as code owners February 4, 2025 10:55
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Logo
Checkmarx One – Scan Summary & Detailsa0939e25-671d-4d5d-bdc8-980cd618409f

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.18%. Comparing base (d7baa60) to head (a003aeb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13238      +/-   ##
==========================================
- Coverage   35.19%   35.18%   -0.01%     
==========================================
  Files        3128     3128              
  Lines       92667    92667              
  Branches    16854    16854              
==========================================
- Hits        32610    32603       -7     
- Misses      57599    57606       +7     
  Partials     2458     2458              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

audreyality
audreyality previously approved these changes Feb 4, 2025
Copy link
Member

@audreyality audreyality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is good enough, but it could be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants