-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17948] Migrate export from generator legacy to generator core #13238
base: main
Are you sure you want to change the base?
[PM-17948] Migrate export from generator legacy to generator core #13238
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13238 +/- ##
==========================================
- Coverage 35.19% 35.18% -0.01%
==========================================
Files 3128 3128
Lines 92667 92667
Branches 16854 16854
==========================================
- Hits 32610 32603 -7
- Misses 57599 57606 +7
Partials 2458 2458 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is good enough, but it could be improved.
libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts
Outdated
Show resolved
Hide resolved
libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts
Show resolved
Hide resolved
libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts
Show resolved
Hide resolved
…-legacy-to-generator-core
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17948
📔 Objective
Migrate the usage of
@bitwarden/generator-legacy
to@bitwarden/generator-core
Functionality of generating a password for a password protected export stays the same, but uses the new credential-generator services instead.
Relates to #13208
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes