Update for disabled module #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled module have config: ``` [blackfire] ;extension="/usr/local/Cellar/blackfire-php80/1.53.0/blackfire.so" blackfire.agent_socket = unix:///usr/local/var/run/blackfire-agent.sock ;blackfire.log_level = 3 ;blackfire.log_file = /tmp/blackfire.log ``` Now I have error on update: ``` ==> Upgrading blackfireio/blackfire/blackfire-php80 1.53.0 -> 1.54.0 ==> Downloading https://packages.blackfire.io/homebrew/blackfire-php_1.54.0-darwin_amd64-php80.tar.gz ######################################################################## 100.0% Error: An exception occurred within a child process: Utils::Inreplace::Error: inreplace failed /usr/local/etc/php/8.0/conf.d/ext-blackfire.ini: expected replacement of /^(zend_)?extension=.+$/ with "extension=\"/usr/local/Cellar/blackfire-php80/1.54.0/blackfire.so\"" ```
|
@romainneutron can you review and merge PR? |
|
@fabpot can you check PR and merge? |
jderusse
reviewed
Sep 3, 2021
Co-authored-by: Jérémy Derussé <[email protected]>
|
LGTM |
|
merge it please~~~ I often disable it for xdebug's compatiblity. |
|
@blackfire-tortue-geniale any chance to get this PR merged? This error still happens with every update ==> Upgrading blackfireio/blackfire/blackfire-php74
1.74.1 -> 1.75.0
Error: An exception occurred within a child process:
Utils::Inreplace::Error: inreplace failed
/opt/homebrew/etc/php/7.4/conf.d/ext-blackfire.ini:
expected replacement of /^(zend_)?extension=.+$/ with "extension=\"/opt/homebrew/Cellar/blackfirephp74/1.75.0/blackfire.so\"" |
pierredup
reviewed
Mar 4, 2022
| @@ -164,7 +164,7 @@ def config_filepath | |||
| def write_config_file | |||
| if config_filepath.file? | |||
| inreplace config_filepath do |s| | |||
| s.gsub!(/^(zend_)?extension=.+$/, "extension=\"#{module_path}\"") | |||
| s.gsub!(/^(;\s*)?(zend_)?extension=.+$/, "extension=\"#{module_path}\"") | |||
There was a problem hiding this comment.
Should it not be
Suggested change
| s.gsub!(/^(;\s*)?(zend_)?extension=.+$/, "extension=\"#{module_path}\"") | |
| s.gsub!(/^(;\s*)?(zend_)?extension=.+$/, "\\1extension=\"#{module_path}\"") |
Otherwise, it explicitly enables the module which has been disabled, so it must be manually disabled again.
|
Is there any chance to get this PR merged? This error still happens with every update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled module has config:
I have error on update: