cleanup parseBool (git-town#1381)

src/util/string.go

@@ -1,17 +1,15 @@
 package util
 
 import (
-	"fmt"
-	"os"
+	"log"
 	"strconv"
 )
 
 // StringToBool parses the given string into a bool
 func StringToBool(arg string) bool {
 	value, err := strconv.ParseBool(arg)
 	if err != nil {
-		fmt.Printf("cannot convert string %q to bool: %v\n", arg, err)
-		os.Exit(1)
+		log.Fatal(err)
 	}
 	return value
 }

test/steps/configuration_steps.go

@@ -38,7 +38,7 @@ func ConfigurationSteps(suite *godog.Suite, fs *FeatureState) {
 	suite.Step(`^the new-branch-push-flag configuration is now (true|false)$`, func(text string) error {
 		want, err := strconv.ParseBool(text)
 		if err != nil {
-			return fmt.Errorf("cannot parse %q into bool: %w", text, err)
+			return err
 		}
 		have := fs.activeScenarioState.gitEnvironment.DeveloperRepo.Configuration(true).ShouldNewBranchPush()
 		if have != want {
@@ -59,7 +59,7 @@ func ConfigurationSteps(suite *godog.Suite, fs *FeatureState) {
 	suite.Step(`^the new-branch-push-flag configuration is (true|false)$`, func(value string) error {
 		b, err := strconv.ParseBool(value)
 		if err != nil {
-			return fmt.Errorf("cannot parse %q into bool: %w", value, err)
+			return err
 		}
 		fs.activeScenarioState.gitEnvironment.DeveloperRepo.Configuration(false).SetNewBranchPush(b, false)
 		return nil
@@ -83,15 +83,6 @@ func ConfigurationSteps(suite *godog.Suite, fs *FeatureState) {
 		return nil
 	})
 
-	suite.Step(`^the new-branch-push-flag configuration is set to (true|false)$`, func(text string) error {
-		value, err := strconv.ParseBool(text)
-		if err != nil {
-			return fmt.Errorf("cannot parse %q into bool: %w", text, err)
-		}
-		_ = fs.activeScenarioState.gitEnvironment.DeveloperRepo.Configuration(false).SetNewBranchPush(value, false)
-		return nil
-	})
-
 	suite.Step(`^the perennial branches are not configured$`, func() error {
 		fs.activeScenarioState.gitEnvironment.DeveloperRepo.Configuration(false).DeletePerennialBranchConfiguration()
 		return nil