-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus metrics - Redo #15514
Add prometheus metrics - Redo #15514
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
@NickM-27 how am I supposed to address the merge commit blocked issue? |
This will need to target 0.16, I think it should be good to go now though once another maintainer can take a look |
thank you! |
Looks like the merge with the 0.16 branch brought in more changes than the original PR. The only thing I'd like to see is at least a mention somewhere in the docs for the new functionality/capabilities that this PR offers. |
Ok I added docs.. Not sure how many files i should check in for docs. I ran it locally, it had a ton of docs changed.. let me know if Im supposed to check all the newly generated files in? |
I'd drop this under the Integrations sidebar entries under MQTT rather than Configuration. Otherwise, looks good. |
Generally you are going to be better off rebasing your work on the 0.16 branch. That will get rid of the extra unrelated changes so the PR is cleaner. |
* Update iframe interval recommendation * clarify * tweaks * wording
8e29fec
to
d5a4cf3
Compare
redoing on new branch -> #15521 |
Redo of -> #5594
Addresses #2266
Proposed change
This PR adds comprehensive Prometheus metrics support to Frigate, enabling better monitoring and observability of the system. The integration:
/metrics
endpoint in Prometheus formatThis will allow users to:
The implementation piggybacks on the existing stats collection system, ensuring minimal overhead while providing valuable monitoring capabilities.
Type of change
Additional information
Checklist
ruff format frigate
)Additional Notes: