Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera name to tracked object update mqtt #16124

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ttopholm
Copy link

Proposed change

Adding the camera name in the tracked_object_update, so you don't need to look up the camera name in the api, when using the tracked_object_update. This will make it easier for notifications in Home Assistant

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Make it easier to get the camera name in the tracked_object_update
Adding camera to docs
Adding camera to tracked_object_update
Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit c330648
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6793e79cb784cb000802bcfc
😎 Deploy Preview https://deploy-preview-16124--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hawkeye217
Copy link
Collaborator

I'm not sure this is something we want to do, particularly since any and all associated data can be obtained with another simple API call. This is a metadata-specific topic and adding more than the event id and the actual field that was updated makes the case for adding more fields, potentially ballooning into a duplicate of the events topic.

Curious to hear if the other maintainers have thoughts.

A user posted a good use case for Home Assistant automations here: #15141

@ttopholm
Copy link
Author

Hi @blakeblackshear the reason for the camera name, was actually for not making a new api call ;-), but I can follow with not adding too many fields. But in this case, you will have everything for a meaningful notification.

@hawkeye217
Copy link
Collaborator

you will have everything for a meaningful notification

Maybe it is everything you need, but other users may not think that and want more fields. A second call to the API can easily retrieve whatever else is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants