feat:Added parser code (that does not build tree) #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote a basic parser class that needs functionality
The parser does not build a tree but it parses the tokens and returns an error if the format is wrong.
5 tasks
bliutech
requested changes
Jul 16, 2024
bliutech
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Overall, great work! 😄 There are still a few areas that need fixing based on previous comments (for example, test cases are not properly written using unittest as specified in previous comments and on the original GitHub Issue). I will handle these my fixes this time but please test your code carefully and read the instructions carefully to resolve everything we discussed! Good work! 😄 This one was a tough one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates for issue #12
Test Plan
I wrote a test case that it completely parses through: ["!", "(", "A", "&", "!", "B", "|", "C", ")"]