Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update visitor.py #33

Merged
merged 40 commits into from
Jul 17, 2024
Merged

feat: Update visitor.py #33

merged 40 commits into from
Jul 17, 2024

Conversation

sanjanamandadi
Copy link
Collaborator

Summary

Closes #

Test Plan

@sanjanamandadi sanjanamandadi linked an issue Jul 16, 2024 that may be closed by this pull request
Parser: Write a Visitor to Traverse the AST #17
Closed
3 tasks
@sanjanamandadi
feat: Update visitor.py
81edb4f 
The longer I look at this, the more I think I still may have misunderstood. Let me know!
@bliutech bliutech self-requested a review July 17, 2024 05:04
bliutech
bliutech approved these changes Jul 17, 2024
View reviewed changes
Copy link
Owner

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes need to be made to this. I can help resolve it. Good start!

bliutech and others added 25 commits July 16, 2024 22:21
@bliutech
feat(solver): add framework for solver module
b7899e4
@bliutech
format: lint solver module
aace0ab 
Oops, I make these mistakes too. 😋
@timoslater @bliutech
Create parser/README.md
f21d754
@timoslater @bliutech
Add parsing table and grammar to parser/README.md
b1c0439
@timoslater @bliutech
feat: add abstract syntax tree nodes
33cf742
@timoslater @bliutech
docs: add first and follow function table to README.md
3a95b31
@timoslater @bliutech
docs: add docstrings to AST node classes
8591b50
@timoslater @bliutech
style: rename term and Expr for clarity
4832e84
@timoslater @bliutech
docs: change term and Expr names for clarity in README.md
9a6624e
@timoslater @bliutech
feat!: revise ast node classes
8f7be4e
@timoslater @bliutech
feat!: condense AndExpr, OrExpr, NotExpr, and ParenExpr, to terminal …
4cc6bf1 
…operators
@timoslater @bliutech
docs: replace AND, OR, and NOT, with &, | and !
11dba97
@timoslater @bliutech
docs: replace AND, OR, and NOT, with &, | and !
be94c72
@timoslater @bliutech
docs: convert Var to non-terminal
e9882ca
@timoslater @bliutech
refactor: allow Expr to accept None for nullable ExprPrime
a9bbea0
@timoslater @bliutech
refactor: restore ParenExpr and remove parenthesis operators
3f3d2aa
@timoslater @bliutech
refactor: restore AndExpr, OrExpr, NotExpr; inherit from Expr and/or …
2ba384e 
…ExprPrime; remove old docstrings
@timoslater @bliutech
docs: fix incorrect table and inaccurate EBNF title
ec6196a
@timoslater @bliutech
docs: fix table centering
8fc6bae
@timoslater @bliutech
refactor: add VarExpr, convert Expr and ExprPrime to parent classes/i…
e4202c2 
…nterfaces
@bliutech
fix(nit): add small nit fixes
38169fd
@micah-0w0 @bliutech
Update parse.py
3641913 
Wrote a basic parser class that needs functionality
@micah-0w0 @bliutech
Create test_parse.py
c0a3a8a
@micah-0w0 @bliutech
Update parse.py
ff5382d
@micah-0w0 @bliutech
update parse.py (outlined the code)
08fe5a0
@bliutech bliutech closed this Jul 17, 2024
@bliutech bliutech reopened this Jul 17, 2024
@bliutech bliutech merged commit 37f8496 into main Jul 17, 2024
3 checks passed
@bliutech bliutech deleted the 17-parser-write-a-visitor-to-traverse-the-ast branch July 17, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bliutech bliutech bliutech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser: Write a Visitor to Traverse the AST
4 participants
@sanjanamandadi @bliutech @timoslater @micah-0w0