Skip to content

Commit

Permalink
fix: reduce ASM batch size to stay within filter limit of 10 (#1940)
Browse files Browse the repository at this point in the history
fixes #1937
Not able to reproduce the issue in local stack. A tag filter + 20 secret
names worked fine there.
  • Loading branch information
matt2e authored Jul 2, 2024
1 parent 382ba8b commit 116e8ac
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion common/configuration/asm_leader.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ func (l *asmLeader) sync(ctx context.Context, secrets *xsync.MapOf[Ref, cachedSe

// get values for new and updated secrets
for len(refsToLoad) > 0 {
batchSize := 20
// ASM returns an error when there are more than 10 filters
// A batch size of 9 + 1 tag filter keeps us within this limit
batchSize := 9
secretIDs := []string{}
for ref := range refsToLoad {
secretIDs = append(secretIDs, ref.String())
Expand Down

0 comments on commit 116e8ac

Please sign in to comment.