feat: changesets #4253
Merged
feat: changesets #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
stuartwdouglas/changeset/squash
branch
7 times, most recently
from
c792fdd to
394de04
Compare
This was referenced Jan 31, 2025
Open
Open
small updates in todos tmp: changes fixes some progress kinda works getting closer progress it deploys some work tmp changes more tmp more work fix: more stuff minor lint routing needs work logs test fixes update frequency
stuartwdouglas
force-pushed
the
stuartwdouglas/changeset/squash
branch
from
dbfb896 to
e6ff674
Compare
wesbillman
reviewed
Jan 31, 2025
| @@ -28,6 +29,7 @@ test('send cron request', async ({ page }) => { | |||
| test('submit cron form using ⌘+⏎ shortcut', async ({ page }) => { | |||
| await navigateToDecl(page, 'cron', 'thirtySeconds') | |||
|
|
|||
| await setVerbRequestBody(page, '{}') | |||
There was a problem hiding this comment.
@stuartwdouglas I think this is why the test was failing before. This bug probably existed before your PR btw, we just never hit the failure case here. Basically it was pressing the keyboard shortcut before the page had fully loaded and the request body was available. This should fix that.
Comment on lines
+15
to
+21
| const readyModules = modules.filter((module) => { | ||
| const moduleElement = document.querySelector(`li#module-tree-module-${module}`) | ||
| if (!moduleElement) return false | ||
|
|
||
| const greenDot = moduleElement.querySelector('.bg-green-400') | ||
| return greenDot !== null | ||
| }) |
There was a problem hiding this comment.
This will make the "ready check" make sure the green dots are visible for all the modules we're starting.
Comment on lines
+81
to
+84
| // First subscribe to new events to avoid missing any | ||
| events := make(chan *buildenginepb.EngineEvent, 64) | ||
| u.engine.EngineUpdates.Subscribe(events) | ||
| defer u.engine.EngineUpdates.Unsubscribe(events) |
There was a problem hiding this comment.
I think this is just better before we play the history. I'm not sure if this was part of the blue dots showing when the terminal is happy, but thought I'd point it out.
stuartwdouglas
force-pushed
the
stuartwdouglas/changeset/squash
branch
from
464306d to
8d25762
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/changeset/squash
branch
from
8d25762 to
9a78f1d
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/changeset/squash
branch
from
4c5d155 to
a28a339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the concept of a changeset. All modules are now deployed in a single changeset, which has removed some of the ordering invariants around deployments that we previously had with dependencies. For now this has been worked around with a 'retry until it works' approach, however significant further changes are required to get changesets to the desired end state.