Skip to content

Commit

Permalink
fix: pr comment workflow by adding job output (#760)
Browse files Browse the repository at this point in the history
  • Loading branch information
salman1993 authored Jan 24, 2025
1 parent 28c9f99 commit 2e99e17
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/pr-comment-bundle-desktop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ jobs:
trigger-on-command:
name: Trigger on ".bundle" PR comment
runs-on: ubuntu-latest
outputs:
continue: ${{ steps.command.outputs.continue }}
comment_id: ${{ steps.command.outputs.comment_id }}
steps:
- uses: github/[email protected]
id: command
Expand All @@ -34,7 +37,8 @@ jobs:

bundle-desktop:
# Only run this if ".bundle" command is detected.
if: ${{ steps.command.outputs.continue == 'true' }}
needs: [trigger-on-command]
if: ${{ needs.trigger-on-command.outputs.continue == 'true' }}
uses: ./.github/workflows/bundle-desktop.yml
with:
signing: true
Expand All @@ -61,7 +65,7 @@ jobs:
- name: Comment on PR with download link
uses: peter-evans/create-or-update-comment@v3
with:
comment-id: ${{ steps.command.outputs.comment_id }}
comment-id: ${{ needs.trigger-on-command.outputs.comment_id }}
issue-number: ${{ github.event.pull_request.number }}
body: |
### Desktop App for this PR
Expand Down

0 comments on commit 2e99e17

Please sign in to comment.