feat: Dynamically Link back to the Goose homepage from the extensions site #953
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-w-nick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if you're on the extensions site homepage and click the goose icon in the top left corner, it doesn't go anywhere. That's because it's meant to be clicked while on an extensions detail page so it takes you back to the main extensions page.
This has a downside due to this link being hardcoded to
"/", and since the extensions site and the main site are separate projects, the extensions site treats the"/"path (its' homepage) as the root instead of the actual goose homepage.To get the best of both worlds, I've made it so that if you're on an extension detail page, the goose icon will still redirect you back to the extension site homepage, but if you click the icon while you're on the extension home page, it will redirect you back to the main goose site, as you would normally expect since they are on the same domain.