[FIX] Iso format for v3 is called twice #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2021
Merged
.travis.yml
Outdated
| @@ -1,7 +1,6 @@ | |||
| sudo: false | |||
| language: python | |||
| python: | |||
| - "2.7" | |||
| - "3.6" | |||
There was a problem hiding this comment.
why removing the 2.7 version?
| return datetime.now(timezone.utc).isoformat()[:-13]+'Z' |
There was a problem hiding this comment.
that looks good, now that I look at the other code, it was indeed a strange setup.
lemoustachiste
requested changes
Apr 27, 2021
There was a problem hiding this comment.
@flachica we had a discussion with @lparkerlm and as it stands, removing python 2.7 cannot be accepted as part of this PR. We need more time to flesh out the issue with this version, and decide if we maintain or remove support.
In my opinion your code looks ok, and if it works with Python 3, then I think it's good enough for the current purpose. Python 2.7 issue has been lingering for a while, so we would need to take a proper look at it.
lemoustachiste
approved these changes
May 10, 2021
antonellopasella-kedos
added a commit
to antonellopasella-kedos/cert-tools
that referenced
this pull request
Jul 21, 2021
As of this issue blockchain-certificates#48 and the PR blockchain-certificates#49 (paused for Python3 concerns) I proposte this PR to only put the correct datetime format without any Python3 upgrade
Open
|
Updated without Python3 removal in #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.